fix: using special characters in attribute static strings #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus
reviewed
Nov 13, 2024
| <div foo1="bar" class="before:block before:content-['Festivus']">no interpolation</div> | ||
| <div foo2="${'bar'}">single attribute interpolation</div> | ||
| <div foo3="${'bar'}" bar="${'baz'}">multiple attribute interpolations</div> | ||
| <div foo4="${'bar'} baz ${'foo'} before:content-['Festivus']"> |
There was a problem hiding this comment.
what about the unquoted case ?
https://arc.net/l/quote/neouemuc
do we still test this somewhere ?
There was a problem hiding this comment.
And what exatly is this.
baz ${'foo'}
Just having a single/static interpolation somewhere through ${'foo'} ?
I mean .. it's cool but isn't it the same as conditional attributes ?
There was a problem hiding this comment.
This is just an example element for debugging things in the browser through the dev server. The unquoted case is tested somewhere else.
baz ${'foo'} is showing what it looks like when attributes have interpolations inside static parts of the attribute value.
quarkus
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #134