Skip to content

Commit

Permalink
ruffle: update to ruffle 2023-05-13 release, later versions interfere… (
Browse files Browse the repository at this point in the history
#181)

* ruffle:
- switch to ruffle 2023-05-13 release, later versions interfere with loading, it seems (see #180)
fixes #180

* add ruffle toggling options
- disable by default in embed mode, can be enabled with 'useruffle' attr
- enable by default in standalone, can be disabled with 'skipruffle' attr
- fixes #182

* update CHANGES for 1.8.1
  • Loading branch information
ikreymer authored Jun 16, 2023
1 parent b26f4b0 commit f8116ee
Show file tree
Hide file tree
Showing 13 changed files with 45 additions and 26 deletions.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

v1.8.1
- Loading: Resolve sourceUrl to absolute url when computing default id
- Loading: Disable ruffle on embeds by default, can enable with 'useruffle', enable on standalone by default, can disable with 'skipruffle' attr
- Dependencies: Switch to ruffle 2023-05-13 due to issues in later versions

v1.8.0
- UI: Add 'Show All Pages' option to show non-seed pages that are previously only available via search
Expand Down
1 change: 1 addition & 0 deletions docs/embedding.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ The `<replay-web-page>` tag is a web component that supports a number of additio
| `newWindowBase` | set base replay URL loaded when a page opens a new window, defaults to `https://replayweb.page/` if `deepLink` not enabled, otherwise, to current page with new link. |
| `requireSubdomainIframe` | if set, will only load embed in an iframe loaded from a subdomain, for increased origin isolation. |
| `loading="eager"` | if set, will load the entire WACZ file at once (regardless of size), and not attempt on-demand range request loading. |
| `useRuffle` | if set, will enable include Ruffle Flash emulator. Must include the `ruffle/` directory in `replayBase`. |

### Versioning

Expand Down
Binary file removed ruffle/8988d11439726031fb0c.wasm
Binary file not shown.
2 changes: 1 addition & 1 deletion ruffle/LICENSE_MIT
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2018 Mike Welsh <[email protected]>
Copyright (c) 2018 Ruffle LLC <[email protected]> and Ruffle contributors

Permission is hereby granted, free of charge, to any
person obtaining a copy of this software and associated
Expand Down
2 changes: 0 additions & 2 deletions ruffle/core.ruffle.671e8308f154108396e3.js

This file was deleted.

2 changes: 0 additions & 2 deletions ruffle/core.ruffle.7b401a0204b092cdbb42.js

This file was deleted.

Binary file removed ruffle/dce2c4b91f5b7ef43cf0.wasm
Binary file not shown.
3 changes: 1 addition & 2 deletions ruffle/ruffle.js

Large diffs are not rendered by default.

16 changes: 15 additions & 1 deletion src/appmain.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class ReplayWebApp extends LitElement
this.collTitle = null;
this.showAbout = false;
this.showFileDropOverlay = false;

this.pageParams = new URLSearchParams();

this.inited = false;
Expand All @@ -31,6 +32,9 @@ class ReplayWebApp extends LitElement
this.swName = swName;
this.swmanager = null;

this.skipRuffle = false;
this.useRuffle = false;

this.safariKeyframes();

this.addEventListener("dragenter", (dragEvent) => {
Expand Down Expand Up @@ -88,6 +92,7 @@ class ReplayWebApp extends LitElement
pageTitle: { type: String },
pageReplay: { type: Boolean },
source: { type: String },
skipRuffle: { type: Boolean },

swErrorMsg: { type: Object },
};
Expand Down Expand Up @@ -323,7 +328,10 @@ class ReplayWebApp extends LitElement
firstUpdated() {
this.initRoute();

this.swmanager = new SWManager({name: this.swName, appName: this.appName});
// service worker name
const name = this.swName + (this.useRuffle ? "?ruffle=1" : "");

this.swmanager = new SWManager({name, appName: this.appName});
this.swmanager.register().catch(() => this.swErrorMsg = this.swmanager.renderErrorReport(this.mainLogo));

window.addEventListener("popstate", () => {
Expand Down Expand Up @@ -414,6 +422,12 @@ class ReplayWebApp extends LitElement
this.sourceUrl = this.pageParams.get("source") || "";
this.embed = this.pageParams.get("embed") || "";

if (!this.embed) {
this.useRuffle = !this.skipRuffle;
} else {
this.useRuffle = this.pageParams.get("ruffle") === "1";
}

if (this.pageParams.has("terms")) {
this.showAbout = true;
}
Expand Down
7 changes: 7 additions & 0 deletions src/embed.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ class Embed extends LitElement
this.noSandbox = null;
this.logo = rwpLogo;
this.loading = "";
this.useRuffle = false;
}

static setDefaultReplayFile(replayfile) {
Expand Down Expand Up @@ -88,6 +89,8 @@ class Embed extends LitElement
requireSubdomainIframe: {type: Boolean},

loading: { type: String },

useRuffle: { type: Boolean },
};
}

Expand Down Expand Up @@ -252,6 +255,10 @@ class Embed extends LitElement
params.swName = this.swName;
}

if (this.useRuffle) {
params.ruffle = "1";
}

this.paramString = new URLSearchParams(params).toString();

this.hashString = new URLSearchParams({
Expand Down
12 changes: 6 additions & 6 deletions src/sw.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ if (self.registration) {

staticData.set(prefix, {type: "text/html", content: INDEX_HTML});
staticData.set(prefix + "index.html", {type: "text/html", content: INDEX_HTML});
//staticData.set(prefix + "ui.js", {type: "application/javascript", content: UI_JS});

//const { SWReplay } = require('@webrecorder/wabac/src/swmain');
const sp = new URLSearchParams(self.location.search);

const defaultConfig = {
injectScripts: ["ruffle/ruffle.js"],
};
const defaultConfig = {};

if (sp.get("ruffle") == "1") {
defaultConfig.injectScripts = ["ruffle/ruffle.js"];
}

self.ipfsCustomPreload = true;
self.sw = new SWReplay({staticData, defaultConfig});
} else {
new WorkerLoader(self);
Expand Down
2 changes: 1 addition & 1 deletion sw.js

Large diffs are not rendered by default.

22 changes: 11 additions & 11 deletions ui.js

Large diffs are not rendered by default.

0 comments on commit f8116ee

Please sign in to comment.