ui: Public Collections UI Nitpicks #2287
Conversation
| maxlength=${4000} | ||
| ></btrix-markdown-editor> | ||
| <div class="flex justify-center leading-relaxed"> | ||
| <div class="w-full md:max-w-[783px]"> |
There was a problem hiding this comment.
Where does the 783px value come from? Can we use one of the CSS variables here, or em or ch?
There was a problem hiding this comment.
Comes from being sloppy while trying to figure out a comfortable value 🙃
Do we have a global value that we use for max-width with text? On the site this is part of the prose tailwind typography setting (which I would rather set separately because it's somewhat regularly overruled)... Maybe we should be using that here too?
| </div> | ||
| return html` <section class="overflow-hidden rounded-lg border"> | ||
| <replay-web-page | ||
| class="h-[calc(100vh-6.5rem)]" |
There was a problem hiding this comment.
I'll also note that while I consider this a reasonably good solution (and probably better than using aspect ratio?), it is somewhat fragile and going forward if we make layout changes we'll need to remember to update it. Open to better ideas!
|
A couple more nitpicks — I'll address! Hover issues: Screen.Recording.2025-01-08.at.3.27.02.PM.movCheckmark is hard to see on mostly white image: 
|
Updated check mark!
|
SuaYoo
force-pushed
the
public-collections-ui-improvements
branch
from
bb6ae25 to
c6b39ff
Compare
- "Default" is generally not a good descriptor, could be anything! - That said, we also show the outcome in the image on the left so by no means a serious UI sin as is :)
- Helps ensure the window is always visible in the viewport - Calc accommodates for the navigation & footer height on desktop - Removes sticky and white shadow blur
Fixes #2283
SuaYoo
force-pushed
the
public-collections-ui-improvements
branch
from
0a9de57 to
518f64d
Compare
- Removes share link from the dialogue footer - Removes stickied collection navigation, replaces with improved viewport-based scaling! - Adds a max-width for the collection description in the logged in view. - Moves the markdown editor buttons to below the editor - Controls are now In-line with how we handle dialogue options elsewhere, fixes a minor responsive design issue. - Minor copy changes --------- Co-authored-by: emma <[email protected]> Co-authored-by: sua yoo <[email protected]>
Fixes #2283
Public collections are looking great! This PR covers the few little things I found when exploring the feature.
Changes
Screenshots
Moved share link (not visible because it's private)
Moved share link (visible)
Copy updates
Line length change
Composer Button Relocation
Caveats