Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor page headers #2282

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jan 7, 2025

Resolves #2197

Changes

  • Refactors all page headers to use new pageHeader
  • Removes border under org name/title in the org dashboard

Manual testing

Regression test each page--there should be no visible changes to the page header, besides the dashboard:

Screenshot 2025-01-07 at 2 42 54 PM

@SuaYoo SuaYoo requested a review from emma-sg January 7, 2025 23:11
@SuaYoo SuaYoo marked this pull request as ready for review January 7, 2025 23:11
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SuaYoo SuaYoo merged commit b103e79 into public-collections-feature Jan 8, 2025
3 checks passed
@SuaYoo SuaYoo deleted the frontend-refactor-page-headers branch January 8, 2025 00:21
SuaYoo added a commit that referenced this pull request Jan 9, 2025
- Refactors all page headers to use new `pageHeader`
- Removes border under org name/title in the org dashboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants