Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crawler proxy selection fixes #2280

Merged
merged 4 commits into from
Jan 9, 2025
Merged

fix: Crawler proxy selection fixes #2280

merged 4 commits into from
Jan 9, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jan 7, 2025

Fixes #2168

Changes

  • Hides proxy form control if there are no proxy servers available
  • Fixes org default proxy value not being saved

Manual testing

  1. Log in as superadmin
  2. Select org with proxies
  3. Go to Settings -> Crawling Defaults. Verify "Crawler Proxy Server" is available
  4. Update "Crawler Proxy Server" and save
  5. Go to Crawling -> New Workflow -> Crawling Settings. Verify correct default proxy is shown
  6. Go to Browser Profiles -> New Browser Profile. Verify "Crawler Proxy Server" is available
  7. Select different org without proxies
  8. Repeat 3-6, only verify that "Crawler Proxy Server" is not visible and forms save as expected

Follow-ups

Browser profile proxies need some updates, see #2281

Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see us start using @lit/context! I take it #2281 will be addressed separately?

Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great!

@SuaYoo SuaYoo merged commit 1260aec into main Jan 9, 2025
3 checks passed
@SuaYoo SuaYoo deleted the frontend-fix-crawler-proxy branch January 9, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Hide Crawler Proxy Server setting if no proxies are available
3 participants