Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last crawl and subscription status indicators to org list #2273

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Jan 7, 2025

Fixes #2260

  • Adds lastCrawlFinished to Organization model, updated after crawls are added/deleted and with an idempotent migration to backfill existing orgs (migration is 0038 to account for migrations in feat: Public collections #2271)
  • Adds Last Crawl column to end of admin orgs list table
  • Adds subscription icon next to existing status icon in orgs list
  • Adds "lastCrawlFinished", "subscriptionStatus", and "subscriptionPlan" sort options to orgs list backend endpoint in anticipation of future sorting/filtering of orgs list (best handled in a separate PR, though the client-side searching added in Add fuse-backed org search to superadmin org list #2277 may make this less pressing)

Note

Should be merged after #2271 so migrations stay in correct order

Screenshots

Subscription status

(Taken with local frontend against dev backend - update when we can push this to dev and populate the Last Crawl field)

Screenshot 2025-01-07 at 10 24 36 AM Screenshot 2025-01-07 at 10 25 19 AM

Last crawl

(Taken with local frontend and backend, no subscriptions)

Screenshot 2025-01-07 at 11 53 19 AM

Testing

  • Deploy locally or to dev
  • Verify that orgs with crawls now have lastCrawlFinished
  • Go to orgs list and verify that last crawl and subscription indicator are present

@tw4l tw4l requested review from SuaYoo and emma-sg January 7, 2025 16:52
@tw4l tw4l requested a review from ikreymer January 7, 2025 16:52
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good!

Copy link
Member

@SuaYoo SuaYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tried to give some of the icons more distinct options? Having two status icons next to eachother without labels is a bit of a low point of our table row styling... Will probably give this some more thought in the future as it also relates to collections & archived items, but good enough for now! A helpful indicator to have in the list!

frontend/src/components/orgs-list.ts Outdated Show resolved Hide resolved
frontend/src/components/orgs-list.ts Outdated Show resolved Hide resolved
frontend/src/components/orgs-list.ts Outdated Show resolved Hide resolved
frontend/src/components/orgs-list.ts Outdated Show resolved Hide resolved
frontend/src/components/orgs-list.ts Outdated Show resolved Hide resolved
frontend/src/components/orgs-list.ts Outdated Show resolved Hide resolved
frontend/src/components/orgs-list.ts Outdated Show resolved Hide resolved
frontend/src/components/orgs-list.ts Outdated Show resolved Hide resolved
@ikreymer ikreymer marked this pull request as draft January 9, 2025 02:09
@ikreymer
Copy link
Member

ikreymer commented Jan 9, 2025

Looks good, just converted to draft to avoid accidentally merging before the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve superadmin org list
5 participants