Ensure PR workflows can run on all PRs (but still skip when they're not needed) #2237
+469
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emma-sg
added
enhancement
ikreymer
reviewed
Dec 13, 2024
ikreymer
reviewed
Dec 13, 2024
ikreymer
reviewed
Dec 13, 2024
emma-sg
changed the title
SuaYoo
force-pushed
the
simplify-ci-runs
branch
from
4f7d3c1 to
2888f84
Compare
emma-sg
force-pushed
the
simplify-ci-runs
branch
2 times, most recently
from
f40ac3c to
b86d5e8
Compare
SuaYoo
reviewed
Jan 7, 2025
| # In order to be able to have required checks, a workflow can't be entirely | ||
| # skipped: see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks | ||
| paths-filter: | ||
| name: "Filter Paths" |
There was a problem hiding this comment.
The only nitpick I have is that the checks now always show "Filter Paths":
There was a problem hiding this comment.
Yeah, it's frustrating that GitHub actions works this way. With the objective of enabling auto-merge, I'm not sure there's another way around this, but I'm open to ideas if you have any?
There was a problem hiding this comment.
Yeah I'm not seeing a quick solution. Maybe the name could be the objective of the path filtering, something like "Conditional run" or "Run on path match"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2279
This adds a
paths-filterstep to all workflows that run on PRs so that we can enable auto-merge, for more info about this read enabling auto-merge! In order to be able to have required checks, a workflow can't be entirely skipped: see Handling skipped but required checks.This also merges frontend CI workflows into one with multiple parallel steps, which should speed things up a bit. It also upgrades node versions to 20 and 22 across the board.