Move org deletion to background job with access to backend ops classes #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not yet working because of ModuleNotFound import error in container running main_bg.py
Loading from secrets not working, not sure what issue is yet
Likely not the right approach but I wanted to see if it the background job template's inability to load secrets was due to the crawler namespace not having access to them
Job now seems to run and exit successfully but doesn't actually delete the org yet.
tw4l
changed the title
ikreymer
reviewed
Oct 8, 2024
tw4l
commented
Oct 8, 2024
ikreymer
reviewed
Oct 10, 2024
tw4l
added a commit
that referenced
this pull request
Oct 30, 2024
Follow-up to #2098 Updates I missed to nightly org deletion tests following the shift to deleting orgs in a background job. I think this should be the last thing to get nightly tests passing consistently again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1898
This PR introduces background jobs that have full access to the backend ops classes and moves the delete org job to a background job.
We will likely want to move additional functionality into background jobs in subsequent PRs, but I'm hoping to merge this before too long so that we can use it for handling changes to storage as part of #2093
If we want to close the attached issue with this PR, I can split out the additional follow-up tasks into separate issues.