Add API endpoint to recalculate org storage #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made a few small tweaks but should be good for review now @ikreymer :) |
ikreymer
reviewed
Jul 19, 2024
| "/recalculate-storage", tags=["organizations"], response_model=SuccessResponse | ||
| ) | ||
| async def recalculate_org_storage(org: Organization = Depends(org_owner_dep)): | ||
| return await ops.recalculate_storage(org) |
There was a problem hiding this comment.
At first I thought maybe it should return the recalculated storage, but that would make it harder to convert to a bg job, so this makes sense.
ikreymer
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1942
This process might be a bit slow for large orgs, so I added a note to consider moving it to a background job in #1898.