Skip to content

Commit

Permalink
upgrade node
Browse files Browse the repository at this point in the history
  • Loading branch information
SuaYoo committed Jan 7, 2025
1 parent cf1d97a commit a82ed6e
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/frontend-build-prepare.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: 'yarn'
cache-dependency-path: frontend/yarn.lock

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/weblate-reformat.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: 'yarn'
cache-dependency-path: frontend/yarn.lock
- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion frontend/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# syntax=docker/dockerfile:1.4
FROM --platform=$BUILDPLATFORM docker.io/library/node:18 as build_deps
FROM --platform=$BUILDPLATFORM docker.io/library/node:20 as build_deps

WORKDIR /app
COPY .yarnrc yarn.lock package.json ./
Expand Down
4 changes: 2 additions & 2 deletions frontend/docs/docs/develop/frontend-dev.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ Instead of rebuilding the entire frontend image to view your UI changes, you can

The frontend development server requires an existing backend that has been deployed locally or is in production. See [Deploying Browsertrix](../deploy/index.md).

### 2. Node.js ≥18
### 2. Node.js ≥20

To check if you already have Node.js installed, run the following command in your command line terminal:

```sh
node --version
```

You should see a version number like `v18.12.1`. If you see a command line error instead of a version number, [install Node.js](https://nodejs.org/en/download/package-manager) before continuing.
You should see a version number like `v20.17.0`. If you see a command line error instead of a version number, [install Node.js](https://nodejs.org/en/download/package-manager) before continuing.

??? question "What if my other project requires a different version of Node.js?"

Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
}
},
"engines": {
"node": ">=18"
"node": ">=20"
},
"resolutions": {
"**/playwright": "1.49.0",
Expand Down

0 comments on commit a82ed6e

Please sign in to comment.