[pull] develop from NLnetLabs:develop

[pull]

See Commits and Changes for more details.

---

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Bug Fixes:

• Fix an issue where a subtype of 0 in ldns_rdf_bitmap_known_rr_types_set could cause problems.

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request addresses a bug in the ldns_rdf_bitmap_known_rr_types_set function where a subtype value of 0 could cause issues. The fix ensures that the subtype is set to 1 when it is 0, preventing the issue.

Sequence diagram for bitmap type setting with subtype fix

sequenceDiagram
    participant Caller
    participant RDF_Bitmap as ldns_rdf_bitmap_known_rr_types_set

    Caller->>RDF_Bitmap: Set bitmap types
    Note over RDF_Bitmap: For each rdata field descriptor
    RDF_Bitmap->>RDF_Bitmap: Calculate window (type >> 8)
    RDF_Bitmap->>RDF_Bitmap: Calculate subtype (type & 0xff)
    Note over RDF_Bitmap: Check if subtype is 0
    RDF_Bitmap->>RDF_Bitmap: If subtype = 0, set to 1
    RDF_Bitmap->>RDF_Bitmap: Update window if subtype larger
    RDF_Bitmap-->>Caller: Return result

Loading

File-Level Changes

Change	Details	Files
Fixed a bug in ldns_rdf_bitmap_known_rr_types_set where a subtype of 0 could cause issues.	Added a check to ensure that the subtype is not 0. If the subtype is 0, it is set to 1.	rr.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.