Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated @webex/event-dictionary-ts #4073

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

marcin-bazyl
Copy link
Collaborator

COMPLETES #SPARK-604475

This pull request addresses

@webex/event-dictionary-ts that we're using is a bit old, we need a newer version in the web app

by making the following changes

updated @webex/event-dictionary-ts and also added it to dependencies in plugin-meeting, which is using it, but was missing it in package.json

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

unit tests

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@marcin-bazyl marcin-bazyl requested review from a team as code owners January 24, 2025 15:58
Copy link

coderabbitai bot commented Jan 24, 2025

📝 Walkthrough

Walkthrough

This pull request involves dependency updates in two Webex packages: @webex/internal-plugin-metrics and @webex/plugin-meetings. The changes specifically relate to the @webex/event-dictionary-ts dependency. In the internal-plugin-metrics package, the dependency version is updated from ^1.0.1594 to ^1.0.1643. Simultaneously, the plugin-meetings package adds @webex/event-dictionary-ts as a new dependency with version ^1.0.1643. These modifications suggest a coordinated update of the event dictionary library across different packages in the Webex ecosystem, potentially introducing new features or resolving previous library-related issues.

Possibly related PRs


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a492f2 and d41ed78.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • packages/@webex/internal-plugin-metrics/package.json (1 hunks)
  • packages/@webex/plugin-meetings/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: AWS Amplify Console Web Preview
🔇 Additional comments (2)
packages/@webex/internal-plugin-metrics/package.json (1)

40-40: Verify the new version compatibility and existence.

The version update to ^1.0.1643 aligns with the PR objectives. Let's verify this version:

✅ Verification successful

Version update to ^1.0.1643 is valid and compatible

The version exists in the npm registry and maintains the same dependency structure as the previous version, with no breaking changes introduced.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the new version of @webex/event-dictionary-ts

# Check if the version exists in the npm registry
curl -s https://registry.npmjs.org/@webex%2Fevent-dictionary-ts | jq '.versions | has("1.0.1643")'

# Check the version's publish date and any potential breaking changes
curl -s https://registry.npmjs.org/@webex%2Fevent-dictionary-ts | jq -r '.time["1.0.1643"]'

# Compare with the previous version to check for breaking changes
curl -s https://registry.npmjs.org/@webex%2Fevent-dictionary-ts/1.0.1594 | jq -r '.version,.dependencies'
curl -s https://registry.npmjs.org/@webex%2Fevent-dictionary-ts/1.0.1643 | jq -r '.version,.dependencies'

Length of output: 820

packages/@webex/plugin-meetings/package.json (1)

65-65: LGTM! Version is consistent across packages.

The added dependency uses the same version ^1.0.1643 as in internal-plugin-metrics, maintaining consistency across the monorepo.

Let's verify the dependency usage in the codebase:

✅ Verification successful

Dependency is properly used in the codebase

Found usage in packages/@webex/plugin-meetings/src/meeting/index.ts where it imports ClientEvent type from the package. The dependency declaration is justified.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify usage of @webex/event-dictionary-ts in plugin-meetings

# Search for imports/requires of the package
echo "Searching for imports of @webex/event-dictionary-ts in plugin-meetings..."
rg -t ts -t js "from ['\"]\@webex\/event-dictionary-ts['\"]|require\(['\"]\@webex\/event-dictionary-ts['\"]" packages/@webex/plugin-meetings/src/

Length of output: 475


Script:

#!/bin/bash
# Search for any imports or requires of @webex/event-dictionary-ts
echo "Searching for imports/requires in plugin-meetings..."
rg -A 2 "[@]webex/event-dictionary-ts" packages/@webex/plugin-meetings/src/

# Also check package.json to see if it's used in any scripts or other sections
echo -e "\nChecking package.json for other references..."
cat packages/@webex/plugin-meetings/package.json

Length of output: 4002


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4073.d3m3l2kee0btzx.amplifyapp.com

@marcin-bazyl marcin-bazyl added the validated If the pull request is validated for automation. label Jan 24, 2025
@marcin-bazyl marcin-bazyl merged commit 1b746fa into webex:next Jan 27, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants