Bug: Fix abort timeout in waitForVideosToBeWritten #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christian-bromann could you please take a look of this one-liner PR when you get a chance? |
…if videoRenderTimeout reached
mbIkola
force-pushed
the
no-ref/wait-for-videos-bug
branch
from
79707aa to
7a6a653
Compare
christian-bromann
approved these changes
Jan 31, 2024
True, my bad. Fixed at 7a6a653 |
christian-bromann
merged commit 9fe5dcd
into
webdriverio-community:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
abortTimevalue inwaitForVideosToBeWrittenandwaitForVideosToExistcausing script waiting approx 54 years before exitPlease see diff and implementation of
waitForVideosToBeWrittenfor details.Steps to Reporduce:
saveAllVideos = false