Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve the build using rollup #882

Closed
wants to merge 51 commits into from

Conversation

mato533
Copy link
Contributor

@mato533 mato533 commented Dec 21, 2024

Description

To avoid complications of ESM and CJS build, Implement rollup as bundler.

new package

We created new package @wdio/electron-bundler because there are some logic to create rollup configurations.

Feature
  1. provide the utility function to detect input and output parameters autotaticaly.

  2. provide some rollup plugins which is used bundling packages.

rollup configuration

this pull request adds rollup configuration files for each package.

Related Issue

#880

@mato533 mato533 marked this pull request as draft December 23, 2024 16:33
@goosewobbler
Copy link
Member

I think extracting the rollup configs and having another package is ok, I would call it @wdio/electron-bundler - however, there's a lot of code here simply to create rollup config files. I think a simpler approach would be better, I will take a look at it in more depth over the holiday...

@mato533 mato533 marked this pull request as draft December 24, 2024 19:29
@mato533 mato533 marked this pull request as ready for review December 25, 2024 03:20
@mato533 mato533 marked this pull request as draft January 14, 2025 12:54
@mato533 mato533 marked this pull request as ready for review January 20, 2025 12:18
@mato533
Copy link
Contributor Author

mato533 commented Jan 20, 2025

@goosewobbler
I simplified the new package to provide some utility functions and Rollup-Plugins.

CI for Linux is currently not working, but once #896 is resolved, it will become normal. In addition, we have confirmed that CI can pass on ubuntu22.

@mato533 mato533 closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants