Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the build - better use of bundling #880

Open
goosewobbler opened this issue Dec 20, 2024 · 2 comments · May be fixed by #898
Open

Improve the build - better use of bundling #880

goosewobbler opened this issue Dec 20, 2024 · 2 comments · May be fixed by #898
Labels
good first issue Good for newcomers help wanted Extra attention is needed tooling
Milestone
8.0.0

Comments

@goosewobbler
Copy link
Member

goosewobbler commented Dec 20, 2024 •
edited
Loading

We're currently not bundling the service, apart from the inject-dependency script which uses rollup to replace a dynamic import of @vitest/spy with the bundle of that module. Bundling everything from ESM into CJS and ESM is likely to have the following benefits:
@goosewobbler goosewobbler added this to the 8.0.0 milestone Dec 20, 2024
@goosewobbler goosewobbler added good first issue Good for newcomers help wanted Extra attention is needed tooling labels Dec 20, 2024
@goosewobbler goosewobbler mentioned this issue Dec 20, 2024
Merged
@mato533
Copy link
Contributor

mato533 commented Dec 20, 2024

@goosewobbler
thank you for considerations!

I often use rollups, so I'll try creating a PR. I'll also include some ideas for making the setup more efficient.

@goosewobbler
Copy link
Member Author

goosewobbler commented Dec 20, 2024 •
edited
Loading

@mato533 that's great, will be good to simplify things and streamline the build. The CJS build has been through a few iterations already but I knew it could still be improved. It has been quite annoying to work on, almost as annoying as what I had to do to get the E2Es to work on Forge which doesn't support PNPM....

@mato533 mato533 mentioned this issue Dec 21, 2024
Closed
@mato533 mato533 linked a pull request Jan 20, 2025 that will close this issue
Open
@mato533 mato533 linked a pull request Jan 20, 2025 that will close this issue
feat: improve the build using rollup #898
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed tooling
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

feat: improve the build using rollup webdriverio-community/wdio-electron-service
2 participants
@goosewobbler @mato533