Sort libraries by GitHub stars #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR: https://custom-elements-everywhere.com/preview/preview/preview/1209/ |
|
Related to #1140 |
| @@ -116,7 +116,8 @@ limitations under the License. | |||
| <div class="level-item has-text-centered"> | |||
| <div> | |||
| <p class="heading">Library</p> | |||
| <h3 class="title">{{fullName}} <span class="library-version">{{results.libraryVersion}}</span></h3> | |||
| <h3 class="title"><a href="{{repo.html_url}}">{{fullName}}</a> <span | |||
| class="library-version">{{results.libraryVersion}}</span></h3> | |||
There was a problem hiding this comment.
Nit and non actionable here. I wonder if there is some way to shorten this or link this to the github version. For example this is very long on React experimental.
Maybe even truncate it with css?
AndrewJakubowicz
approved these changes
Jan 7, 2022
| @@ -119,6 +122,14 @@ async function runTests() { | |||
| return failed; | |||
| } | |||
|
|
|||
| async function fetchMetadata(library) { | |||
| const repoMeta = (await (await fetch(`https://api.github.com/repos/${library.packageJson.library_repo}`)).json()); | |||
Also, since we now need a GH repo for every library, make the name a link to the repo
rictic
force-pushed
the
sort-by-stars
branch
from
f9d370d to
de27398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, since we now need a GH repo for every library, make the name a link to the repo
On the plus side, this means that the info a person is most likely to be curious about will be right at the top
On the minus side, if the library they want to know about isn't near the top, they'll pretty much have to ctrl-f to find it / know whether we have an entry for it or not