Skip to content

merge_pr_49907

Compare
Choose a tag to compare
@github-actions github-actions released this 03 Jan 18:54

Reapply "IDB: direct reads for blobs"

This relands commit 60632268eadd3051d4ec88d62292b160682f8a56.

Difference to original: added support for AsDataPipeGetter and
extended blob-contenttype.any.js WPT to cover this case.

Original change's description:

IDB: direct reads for blobs

For the standard case of a page reading IDB data from the blob store,
don't go through the blob registry on the i/o thread and instead
connect the IDB bucket thread directly to the renderer.

In some other (rarer) cases the blob registry is still used. This
is accomplished by additionally registering a blob with
BlobStorageContext using the same UUID, which is necessary for:

  • WriteBlobToFile(), which does lookup by UUID
  • loading data for a blob:// URL, i.e. mojom::Blob::Load, which is
    thunked through to the registry blob because implementation is non-
    trivial

Bug: 373684390
Change-Id: I9235f23303e4e6a05bf12a8acff32a5fb4e2a565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6113789
Commit-Queue: Evan Stade [email protected]
Reviewed-by: Steve Becker [email protected]
Cr-Commit-Position: refs/heads/main@{#1400627}

Bug: 373684390
Change-Id: Ie555cf4b583b862d306c43e3e4be76e957ea6c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138579
Reviewed-by: Steve Becker [email protected]
Commit-Queue: Evan Stade [email protected]
Cr-Commit-Position: refs/heads/main@{#1401872}