Skip to content

Commit

Permalink
[Credentialless] Fix flakes about iframeTest.js
Browse files Browse the repository at this point in the history
In the various tests, there are up to 8 <iframe> navigating concurrently.

There are no ways to detect an <iframe> fails to load other than using
a timeout. See whatwg/html#125.

The 3000ms timeout was sometimes too short. This cause flakes.
To reduce the rate of false positive, the timeout has been increased to
6000ms.

R: [email protected]
CC: [email protected]
Fixed: 1215956
Bug: 1175099
Change-Id: I7bedccb351ff62d55b6020403aac5457608e5497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2944929
Reviewed-by: Titouan Rigoudy <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#890171}
  • Loading branch information
ArthurSonzogni authored and chromium-wpt-export-bot committed Jun 8, 2021
1 parent 198dd87 commit 78b0123
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const iframeTest = function(
// There are no interoperable ways to check an iframe failed to load. So a
// timeout is being used.
// See https://github.com/whatwg/html/issues/125
step_timeout(()=>send(test_token, "block"), 3000);
step_timeout(()=>send(test_token, "block"), 6000);

assert_equals(await receive(test_token), expectation);
}, description);
Expand Down

0 comments on commit 78b0123

Please sign in to comment.