fix: urllib to join ollama url domain to endpoint in place of string format #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
I agree to the Contributor License Agreement. |
|
Great catch, thanks a lot for the PR 🚀 I'll look into it! |
thomashacker
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #315
DIscussion: https://forum.weaviate.io/t/vectorization-failed-404-http-host-docker-internal-11434-api-embed/7363
It was found that setting the OLLAMA_URL environment variable with a trailing forward slash resulted in the file import endpoint being unable to import files with 404 NOT FOUND for "/api/embed". This change ensures correct url formatting to fix this issue to improve developer experience.