Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: init new workflow to build images (#4468)" #4473

Closed
wants to merge 1 commit into from

Conversation

casibbald
Copy link
Collaborator

Reverts #4468

We Need to resubmit this with potentially a different token

Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't think there is anything wrong with using the GitHub Action token for pushing packages to GHCR. Any remains from the Enterprise setup? We should investigate this more.

@erikgb
Copy link
Contributor

erikgb commented Jan 10, 2025

This issue is fixed now, so no need to revert: https://github.com/weaveworks/weave-gitops/actions/workflows/build-image.yaml?query=branch%3Amain. Roll-forward is always better than rolling back. 😉

@erikgb erikgb closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants