forked from opensearch-project/OpenSearch
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement workflow for automatic ECS templates generation #586
Open
QU3B1M
wants to merge
35
commits into
master
Choose a base branch
from
ci/540-ecs-index-automatic-generation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+578
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QU3B1M
changed the title
Add initial ecs Dockerfile
Implement workflow for automatic ECS templates generation
Dec 10, 2024
Rename local variables to lower case
Update generate.sh script to use env variables
Stop container after each execution
… the updated template
QU3B1M
force-pushed
the
ci/540-ecs-index-automatic-generation
branch
from
December 13, 2024 18:32
44378cc
to
60cf765
Compare
QU3B1M
force-pushed
the
ci/540-ecs-index-automatic-generation
branch
from
December 13, 2024 18:54
15836e7
to
bad34a6
Compare
QU3B1M
force-pushed
the
ci/540-ecs-index-automatic-generation
branch
from
December 13, 2024 20:03
883db15
to
c3b99d1
Compare
…ple modules at once Filter out dirs that dont correspond to any template
QU3B1M
force-pushed
the
ci/540-ecs-index-automatic-generation
branch
from
December 13, 2024 20:32
c3b99d1
to
46e9135
Compare
AlexRuiz7
requested changes
Dec 23, 2024
Update GHA to only run when a json or yml file is edited
Move mapping generator to main ecs directory
QU3B1M
force-pushed
the
ci/540-ecs-index-automatic-generation
branch
from
December 26, 2024 11:31
29b5734
to
da1a00f
Compare
I tested this in a personal fork: The Workflow was failing due to a non-zero exit code in the generate-pr-to-plugins.sh script triggering Fixing that got the PR generation working: |
The latest changes make updates to mappings trigger updates in PR description work. |
QU3B1M
force-pushed
the
ci/540-ecs-index-automatic-generation
branch
5 times, most recently
from
January 6, 2025 16:42
2bc22d8
to
085bdb6
Compare
Update ecs README with new tool usage Update ECS generator script name Remove unused index upload option Fix issue with exit codes on branch checking
QU3B1M
force-pushed
the
ci/540-ecs-index-automatic-generation
branch
from
January 6, 2025 16:45
085bdb6
to
663aab8
Compare
Improve PR body styling
AlexRuiz7
requested changes
Jan 7, 2025
Update GHA workflow to only work on official wazuh-indexer repo Add PR generation tool description at main ECS README
AlexRuiz7
approved these changes
Jan 7, 2025
AlexRuiz7
requested changes
Jan 8, 2025
AlexRuiz7
approved these changes
Jan 8, 2025
Signed-off-by: Kevin Ledesma <[email protected]>
Signed-off-by: Kevin Ledesma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a Docker image that generates ECS index templates based on the mappings definitions, this image is consumed by a Docker Compose that sets all the required env variables and configures the volume where the ECS mappings are stored. A bash utility was generated to handle the execution of the docker compose.
Add another bash tool that launches the ECS mapping generation utility when a modification on a ECS definition is detected, automatically copying the resulting template to
wazuh-indexer-plugins
repository generating a new branch and a PR with the changes.Related Issues
Resolves #540
Working evidence
Mapping generator
GitHub Action ECS utility
Since it requires an GitHub access token to generate the PR, the GHA Workflow was validated on a fork of this repository
GHA bash utility local execution
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.