Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair agent deployment url to documentation #7251

Merged

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Jan 20, 2025

Description

The link to the documentation in the agent password step configuration is not properly defined.

Issues Resolved

Test

Preconditions

Enable the password authentication option by adding the configuration highlighted below to the <auth> section of the Wazuh server configuration file /var/ossec/etc/ossec.conf:

<auth>
  <use_password>yes</use_password>
</auth>
  • Navigate to Agents management > Summary
  • Click on Deploy new agent
  • The password step renders a documentation link

It must navigate to a correct documentation guide:

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Jan 20, 2025
@JuanGarriuz JuanGarriuz marked this pull request as ready for review January 20, 2025 09:58
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 78.72% ( 185 / 235 )
Branches 62.72% ( 69 / 110 )
Functions 61.7% ( 29 / 47 )
Lines 78.72% ( 185 / 235 )

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagen

Test 🟢
CR 🟢

LGTM

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.92% ( 4448 / 29802 )
Branches 9.77% ( 1879 / 19222 )
Functions 14.67% ( 1058 / 7211 )
Lines 15.14% ( 4342 / 28673 )

@Desvelao
Copy link
Member

🟢 Test

image

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit da6bb37 into 4.10.2 Jan 20, 2025
5 checks passed
@Desvelao Desvelao deleted the bug/7247-repair-agent-deployment-url-to-documentation branch January 20, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The documentation link is broken in the agent deployment password step.
3 participants