Fixes 0.16.0 issues #2472
Merged
Fixes 0.16.0 issues #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihovil Ilakovac <[email protected]>
Signed-off-by: Mihovil Ilakovac <[email protected]>
Signed-off-by: Mihovil Ilakovac <[email protected]>
sodic
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Great fix!
Can you please add a type "e2e test" in waspc/todoApp to prevent regressions (define an operation in JS and assert proper types are inferred though our custom type tests)?
Best to do it now while this is still fresh, but we can merge this first and then take care of it in a different PR.
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-router-dom": "^6.26.2", | ||
| "tailwindcss": "^3.2.7" |
There was a problem hiding this comment.
Tailwind wasn't here before. Did you add it on purpose?
There was a problem hiding this comment.
Yes, I did 👍 Forgot to add it when I added it to multiple other places, related to #2464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues found during 0.16.0-rc2 QA: