Make Wasp TS Config projects work with TS project references #2461
+50
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infomiho
approved these changes
Jan 22, 2025
| @@ -65,25 +66,29 @@ nodeModulesDirInWaspProjectDir :: Path' (Rel WaspProjectDir) (Dir NodeModulesDir | |||
| nodeModulesDirInWaspProjectDir = [reldir|node_modules|] | |||
|
|
|||
| -- | NOTE: If you change the depth of this path, also update @waspProjectDirFromProjectRootDir@ below. | |||
| -- TODO: Hm this has different name than it has in Generator. | |||
| generatedCodeDirInDotWaspDir :: Path' (Rel DotWaspDir) (Dir Wasp.Generator.Common.ProjectRootDir) | |||
| -- TODO: Hm this has different name than it has in Generator.Common. | |||
There was a problem hiding this comment.
This TODO doesn't seem to provide any value, let's remove it?
| buildDirInDotWaspDir = [reldir|build|] | ||
|
|
||
| -- Todo: find a better way to define this |
There was a problem hiding this comment.
Could you expand on what do you think could be done better for the folks reading in the future?
| @@ -42,7 +42,7 @@ findWaspFile waspDir = do | |||
| . (waspDir </>) | |||
| <$> find ((suffix `isSuffixOf`) . fromRelFile) files | |||
|
|
|||
| fileNotFoundMessage = "Couldn't find the *.wasp or a *.wasp.ts file in the " ++ fromAbsDir waspDir ++ " directory" | |||
| fileNotFoundMessage = "Couldn't find a *.wasp or a *.wasp.ts file in the directory " ++ fromAbsDir waspDir ++ " ." | |||
There was a problem hiding this comment.
Are you sure about this?
Couldn't find something in the /something/dir directory.
vs.
Couldn't find something in the directory /something/dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #2444 support to Wasp TS config projects,