Add setup video & store ID info to docs #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matijaSos
approved these changes
Jan 7, 2025
| function getYouTubeId(url: string): string | null { | ||
| const regExp = /^.*(youtu.be\/|v\/|u\/\w\/|embed\/|watch\?v=|&v=)([^#&?]*).*/; | ||
| const match = url.match(regExp); | ||
| return match && match[2].length === 11 ? match[2] : null; |
There was a problem hiding this comment.
Why does it have to be 11? Maybe add a comment above explaining it.
| return match && match[2].length === 11 ? match[2] : null; | ||
| } | ||
|
|
||
| const youtubeId = getYouTubeId(src); |
There was a problem hiding this comment.
Suggested change
| const youtubeId = getYouTubeId(src); | |
| const youTubeId = getYouTubeId(src); |
You capitalized "Tube" in other places, so to keep it consistent you should do it here, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the open saas setup walkthrough video to the Getting Started section of docs
also fixes #321
Contributor Checklist