test(store) Restore store test case with multiple engines and compilers #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubianchi
approved these changes
Jan 18, 2021
| @@ -43,7 +43,7 @@ def test_target_with_default_cpu_features(): | |||
| triple = target.Triple.host() | |||
| target_ = target.Target(triple) | |||
|
|
|||
| @pytest.mark.skip(reason = 'CI does not have `gcc` or `clang` installed for the moment. It will be resolved once LLVM is installed.') | |||
| @pytest.mark.skipif(platform.system() == 'Windows', reason = '`clang` is not found on the CI for the moment') | |||
There was a problem hiding this comment.
clang is available with our custom builds. Can't we use it?
There was a problem hiding this comment.
Yup, exactly what I tried in 58a5675, but we are looking for clang, not clang.exe… We should fix that Wasmer itself, or we can symlink temporarily in our CI. Thoughts?
There was a problem hiding this comment.
We should fix that Wasmer itself
👍 for this: can you open an issue there please?
jubianchi
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.