Feat/6724 mobile handling #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've no idea if this is working or not. |
|
I can give it a try but not before next week |
|
@Simounet could you propose us a demo platform? 🙂 |
Simounet
force-pushed
the
feat/6724-mobile-handling
branch
from
3cd1873 to
c700ca4
Compare
|
I didn't upload the right fix. Should be better now. @nicosomb Info sent on Matrix |
|
@Simounet I don't see your messages. |
|
Would love to test this but how? Annotations only work on iPad when using the mouse. Touch doesn’t trigger it. This from what I understand fixes it. If you can guide me on how to test this I would be happy to do so. I am using docker image 2.6.10 currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix wallabag/wallabag#2749
I'm not an heavy user of annotations. Would be great having people testing it. There still a little bit of work to do on the UI side. I've just rotated the annotation icon for testing purpose.
ping @nicosomb