Update to Wagtail 5.2 #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a change from Django 4.1
Merged
William-Blackie
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Hey Dan, great work here. I'm struggling to provide you constructive feedback specific the PR, it looks good and works from testing.
There is however, two side quests, if you choose to accept them.
- Alter the Dockerfile to export the bash aliases again ( I miss
djrun and dj). The file is there, it was just never added. - Alter the Dockerfile to run
createcachetableupon build, it's a minor issues that can be resolved by a developer, but would make the initial setup painless.
These are however, outside the initial scope of this PR, so I will not block this PR.
Thanks - Will.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And Django 4.2 + related package updates.
Replaces modeladmin usage with
ModelViewSetfor packages and taxonomyDoes a bit of tidy-up. The commits are fairly atomic