Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed field name & set field length for PK length limit for Room idempotency #82

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Fixed field name & set field length for PK length limit for Room idempotency #82

merged 2 commits into from
Jan 10, 2025

Conversation

gs18113
Copy link
Collaborator

@gs18113 gs18113 commented Jan 10, 2025 •
edited
Loading

📌 Feature Description

Room 멱등성 해결

🔧 Implementation Details

  • Unique constraint에 들어가는 필드 이름을 알맞게 수정
  • Unique constraint에 Host 추가
  • Address object에 필드 길이 제한을 걸어 PK length limit 오류 해결

✅ Checklist

  • 코드가 컴파일되고 정상적으로 동작
  • 모든 테스트 통과
  • Linter 돌리기
  • 관련 작업 kanban update
  • slack 알림

📝 Related Issues

  • 관련 문제: #

JunBye
JunBye approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@JunBye JunBye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 케아스 통과 확인및 detail 수정 체크하였습니다

@JunBye JunBye merged commit 31516a4 into dev Jan 10, 2025
2 checks passed
@JunBye JunBye deleted the feat/room-idempotency branch January 10, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunBye JunBye JunBye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gs18113 @JunBye