Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed profile&review implementations to match notion requirements #107

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

gs18113
Copy link
Collaborator

@gs18113 gs18113 commented Jan 15, 2025

๐Ÿ“Œ Feature Description

  • Profile Controller

    • ์ˆ˜์ •: GET /api/v1/profile - response์— ๊ณต๊ฐœ ์„ค์ •์„ ํฌํ•จ, profile id ์ œ๊ฑฐ
    • ์ถ”๊ฐ€: GET /api/v1/profile/userId - ๋‹ค๋ฅธ ์‚ฌ๋žŒ ํ”„๋กœํ•„ ์ •๋ณด ๋ถˆ๋Ÿฌ์˜ค๋Š” api
  • Review Controller(๋ฏธ๊ตฌํ˜„ ๋ณผ๋“œ์ฒ˜๋ฆฌ)

    • ์ˆ˜์ •: GET /api/v1/reviews/{reviewId} - hidden ์ฒ˜๋ฆฌ
    • ์ˆ˜์ •: GET /api/v1/reviews/room/{roomId} -
      pagination ์ ์šฉ (์ตœ์‹ ์ˆœ, ๋†’์€ ํ‰์ ์ˆœ, ๋‚ฎ์€ ํ‰์ ์ˆœ)
      Response body ํฌํ•จ ๋‚ด์šฉ:
      • userId
      • nickname
      • profile url link(ํ˜„์žฌ ""๋กœ ๊ตฌํ˜„)
      • content
      • rating
      • startDate
      • endDate
        ํ”„๋ก ํŠธ์—”๋“œ ํŽ˜์ด์ง€์—์„œ ๋ฐฉ๋ณ„ ๋ฆฌ๋ทฐ ๋ชฉ๋ก์„ ๋ณด์—ฌ์ค„ ๋•Œ, ๋‹‰๋„ค์ž„ ๋ฐ‘์— ๋œจ๋˜ ๊ฐ€์ž… ๊ธฐ๊ฐ„์„ ์˜ˆ์•ฝ ๊ธฐ๊ฐ„ ์ •๋ณด๋กœ ์ˆ˜์ •ํ•˜๋Š” ๊ฒƒ์ด ์ข‹์„ ๋“ฏ
    • ์ˆ˜์ •: POST /api/v1/reviews -
      request์— reservationId๊ฐ€ ์žˆ์œผ๋ฏ€๋กœ roomId ํ•„๋“œ๋Š” ๋ถˆํ•„์š”, ์ œ๊ฑฐ
      ์„ฑ๊ณต ์‹œ review id๋งŒ return
    • ์ˆ˜์ •: PUT /api/v1/reviews/{reviewId} -
      ์„ฑ๊ณต ์‹œ review id๋งŒ return
    • ์ˆ˜์ •: GET /api/v1/reviews/user/{userId} -
      Response body ํฌํ•จ ๋‚ด์šฉ:
      • content
      • rating
      • place
      • startDate
      • endDate
        ํ”„๋ก ํŠธ์—”๋“œ์—์„œ ํ•„์š” ์‹œ room ๋Œ€ํ‘œ image url ์ถ”๊ฐ€ ๊ฐ€๋Šฅ
    • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์œ„ ์ˆ˜์ •์— ๋งž๊ฒŒ ์ˆ˜์ •(์ž„์‹œ๋ฐฉํŽธ์œผ๋กœ ์ผ๋ถ€ ์ฃผ์„์ฒ˜๋ฆฌํ•จ)

๐Ÿ”ง Implementation Details

โœ… Checklist

  • ์ฝ”๋“œ๊ฐ€ ์ปดํŒŒ์ผ๋˜๊ณ  ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘
  • ๋ชจ๋“  ํ…Œ์ŠคํŠธ ํ†ต๊ณผ
  • Linter ๋Œ๋ฆฌ๊ธฐ
  • ๊ด€๋ จ ์ž‘์—… kanban update
  • slack ์•Œ๋ฆผ

๐Ÿ“ Related Issues

  • ๊ด€๋ จ ๋ฌธ์ œ: #

@dennis0405 dennis0405 merged commit d381f82 into dev Jan 16, 2025
2 checks passed
@dennis0405 dennis0405 deleted the feat/refactor-profile branch January 16, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants