Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added review&reservation consent field to profile #105

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Added review&reservation consent field to profile #105

merged 5 commits into from
Jan 15, 2025

Conversation

gs18113
Copy link
Collaborator

@gs18113 gs18113 commented Jan 14, 2025

๐Ÿ“Œ Feature Description

Profile์— ๋ฆฌ๋ทฐ ๋ฐ ์˜ˆ์•ฝ ํƒ€์ธ ๊ณต๊ฐœ ์„ค์ •์— ๋Œ€ํ•œ ํ•„๋“œ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ”ง Implementation Details

  • showMyReviews, showMyReservations ํ•„๋“œ ์ถ”๊ฐ€
  • showMyXXX ์„ค์ •์ด ๋˜์–ด ์žˆ์„ ๋•Œ๋งŒ ํƒ€ ์œ ์ € ๋ฐ ๋ฏธ๋กœ๊ทธ์ธ ์œ ์ €์—๊ฒŒ ๋ฆฌ๋ทฐ/์˜ˆ์•ฝ์ด ๋ณด์ด๋„๋ก ์„ค์ •
  • Reservation-by-user, review-by-user, review-by-room์˜ pageable ํŒŒ๋ผ๋ฏธํ„ฐ ์˜ค๋ฅ˜ ์ˆ˜์ •(annotation ์ œ๊ฑฐ)
  • reservation-by-user ๋ฆฌํ„ด ํƒ€์ž… page๋กœ ์ˆ˜์ •
  • Reservation-by-user, review-by-user, review-by-room ์ •์ƒ๋™์ž‘ ํ™•์ธ ์œ„์˜ ํ•„๋“œ๋“ค ์ •์ƒ ๋™์ž‘ํ•˜๋Š”์ง€ ํ™•์ธํ•˜๋Š” ํ…Œ์ŠคํŠธ ์ถ”๊ฐ€

โœ… Checklist

  • ์ฝ”๋“œ๊ฐ€ ์ปดํŒŒ์ผ๋˜๊ณ  ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘
  • ๋ชจ๋“  ํ…Œ์ŠคํŠธ ํ†ต๊ณผ
  • Linter ๋Œ๋ฆฌ๊ธฐ
  • ๊ด€๋ จ ์ž‘์—… kanban update
  • slack ์•Œ๋ฆผ

๐Ÿ“ Related Issues

@dennis0405 dennis0405 merged commit b3df127 into dev Jan 15, 2025
2 checks passed
@dennis0405 dennis0405 deleted the feat/profile-add-consent branch January 15, 2025 13:36
JunBye
JunBye approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@JunBye JunBye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennis0405 dennis0405 dennis0405 approved these changes

@JunBye JunBye JunBye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs18113 @JunBye @dennis0405