Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that a UA may create a new credential from the selection UI #44

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

battre
Copy link
Collaborator

@battre battre commented Dec 23, 2016

Fixes #18


Preview | Diff

@battre battre requested review from mikewest and vabr-g December 23, 2016 09:53
Copy link
Collaborator

@vabr-g vabr-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

index.src.html Outdated
@@ -1738,7 +1738,8 @@ <h4 id="request-siteboundcredential-with-mediation">
Ask the user which {{Credential}} to share.

Note: This behavior is vendor-specific. Guidelines for user agent
behavior are presented in [[#user-mediation]].
behavior are presented in [[#user-mediation]]. A user agent MAY offer
the user to enter and save new credentials in this step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this addition would be better as a statement in https://w3c.github.io/webappsec-credential-management/#user-mediated-selection itself. We're already outlining the requirements for the UI there, so noting this there as well seems clearer.

@battre
Copy link
Collaborator Author

battre commented Jan 2, 2017

I have addressed your comment. PTAL.

@@ -2033,6 +2033,8 @@ <h3 id="user-mediated-selection">Credential Selection</h3>
The chooser interface SHOULD include all {{Credential}} objects associated
with the origin that requested credentials.

The chooser interface MAY offer the user to enter and save new credentials.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like "The chooser interface MAY offer the user the ability to create new credentials directly. For example, the user agent could provide a form which accepted a username and password, and returned a newly-created PasswordCredential containing that information."

It might also be worthwhile to capture @mnoorenberghe's suggestions in #18 in an "Implementation Considerations" section to make it clear why such an interface might be valuable.

Base automatically changed from master to main February 16, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note that a UA may create a new credential from the selection UI
3 participants