Improve coverage GRAPH ?g {}
#160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubensworks
reviewed
Jan 15, 2025
| @@ -0,0 +1 @@ | |||
| SELECT * { GRAPH <unknown> {} } | |||
There was a problem hiding this comment.
unknown should probably become a valid IRI, such as
Suggested change
| SELECT * { GRAPH <unknown> {} } | |
| SELECT * { GRAPH <ex:unknown> {} } |
There was a problem hiding this comment.
<ex:unknown> is fine. Realistically, a URI scheme of ex meaning anything else is asking for trouble!
Aside --
- Registered URI scheme
example:https://www.rfc-editor.org/rfc/rfc7595.html - Registered URN namespace:
urn:example:https://www.rfc-editor.org/rfc/rfc6963.html - DNS TLD
.exampleis defined and, unlikeexample.org, it is guaranteed not to resolve to an IP address.
There was a problem hiding this comment.
It is already a valid IRI because of the implicit base IRI. I have moved to ex:unknown to make it less confusing.
There was a problem hiding this comment.
Thank you for your reviews!
`Graph <...> {}` should return a single empty solution if the graph exists and no solution if it does not
Tpt
force-pushed
the
sparql-more-empty-graph
branch
from
9cd8215 to
16566fa
Compare
afs
approved these changes
Jan 16, 2025
rubensworks
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graph <...> {}should return a single empty solution if the graph exists and no solution if it does not