Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-146: Remove resolution case with two possible answers #148

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

afs
Copy link
Contributor

@afs afs commented Oct 22, 2024

  • IRI-resolution-01 and IRI-resolution-02 in rdf-turtle and rdf-trig.
  • Remove IRI-resolution work files (not in manifest).

This closes #146

@afs afs requested a review from gkellogg October 22, 2024 21:52
IRI-resolution-01 and IRI-resolution-02 in rdf-turtle and rdf-trig.
Remove IRI-resolution work files (not in manifest).
@afs afs requested a review from kasei October 28, 2024 21:49
@kasei
Copy link
Contributor

kasei commented Oct 28, 2024

Change looks good, but why are IRI-resolution.nt and IRI-resolution.trig also removed as part of the PR?

@kasei
Copy link
Contributor

kasei commented Oct 28, 2024

"Not in manifest," meaning entirely unused anywhere?

@afs
Copy link
Contributor Author

afs commented Oct 29, 2024

IRI-resolution.nt and IRI-resolution.trig were work files. They are all the cases in one file, with the base changing as originally created in the community. They have never been in the manifests. They got split into separate files, with one file per base, so each test is now "for this base ...".

@afs afs merged commit 2056c2f into main Oct 29, 2024
1 check passed
@afs afs deleted the resolution branch October 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple correct outcomes for tests IRI-resolution-01 and IRI-resolution-02 (in Turtle and TriG)
3 participants