-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Turtle tests to use triple term syntax and reifications #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are the required updates for the new reifier naming syntax.
…ad of quoted triples.
…r Turtle syntax that should not be acceptable as N-Triples.
c23a7ef
to
5ebe8db
Compare
This was discussed during the rdf-star meeting on 2024-08-29: |
This was discussed during the rdf-star meeting on 12 September 2024. View the transcriptw3c/rdf-tests#135gkellogg: first one has been open for a bit. new tests for updated turtle. AndyS: about at the stage where I can run those tests. ora: so not to merge yet? gkellogg: yeah, let's wait until someone else is passing the tests. |
N-triples tests:
|
I renamed these all as you suggested.
I wasn't able to find these tests in the repository; there are likely some additional tests that would be required. Can you point me to them?
True, if we were to consolidate, which set should remain? |
The simpler |
I didn't see it because the name is slightly different: rdf/rdf12/rdf-n-triples/syntax/ntriples-star-bad-reified-syntax-*.nt. I'll take care of your suggestion. |
This will still need updates for further grammar branches and to reconcile w3c/rdf-turtle#70. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
separators should be space-emdash-space (or space-double hyphen-space), not space-hyphen-space.
</a> | ||
<span about='../syntax#ntriples-star-nested-bad-annotated-syntax-1' property='mf:name'>N-Triples-star - Bad - annotated triple, nested subject term</span> | ||
<span about='../syntax#ntriples-langdir-bad-1' property='mf:name'>N-Triples literal- Bad - undefined base direction</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span about='../syntax#ntriples-langdir-bad-1' property='mf:name'>N-Triples literal- Bad - undefined base direction</span> | |
<span about='../syntax#ntriples-langdir-bad-1' property='mf:name'>N-Triples literal — Bad — undefined base direction</span> |
@@ -482,7 +482,7 @@ <h2> | |||
<a class='testlink' href='#ntriples-star-bad-reified-4'> | |||
ntriples-star-bad-reified-4: | |||
</a> | |||
<span about='../syntax#ntriples-star-bad-reified-4' property='mf:name'>N-Triples-star - Bad - reified triples whitespace and terms</span> | |||
<span about='../syntax#ntriples-star-bad-reified-4' property='mf:name'>N-Triples-star - Bad - predicate reified triple</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span about='../syntax#ntriples-star-bad-reified-4' property='mf:name'>N-Triples-star - Bad - predicate reified triple</span> | |
<span about='../syntax#ntriples-star-bad-reified-4' property='mf:name'>N-Triples-star — Bad — predicate reified triple</span> |
</a> | ||
<span about='../syntax#ntriples-star-nested-bad-annotated-syntax-2' property='mf:name'>N-Triples-star - Bad - annotated triple, nested object term</span> | ||
<span about='../syntax#ntriples-langdir-bad-2' property='mf:name'>N-Triples literal- Bad - upper case LTR</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span about='../syntax#ntriples-langdir-bad-2' property='mf:name'>N-Triples literal- Bad - upper case LTR</span> | |
<span about='../syntax#ntriples-langdir-bad-2' property='mf:name'>N-Triples literal — Bad — upper case LTR</span> |
@@ -168,7 +166,7 @@ trs:ntriples-star-bad-reified-3 rdf:type rdft:TestNTriplesNegativeSyntax ; | |||
. | |||
|
|||
trs:ntriples-star-bad-reified-4 rdf:type rdft:TestNTriplesNegativeSyntax ; | |||
mf:name "N-Triples-star - Bad - reified triples whitespace and terms" ; | |||
mf:name "N-Triples-star - Bad - predicate reified triple" ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mf:name "N-Triples-star - Bad - predicate reified triple" ; | |
mf:name "N-Triples-star — Bad — predicate reified triple" ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the way the tests (all three generations) are. Developers use hyphen.
Keep it simple in the manifest because of viewing with the wrong character set.
The rest is automatically produced.
(FYI: Chicago style guide prefers no spaces around em-dashes, which then looks bad in this context.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I recall, Chicago style guide paradoxically and frustratingly says to put no spaces around em-dashes, but does put spaces around em-dashes. (Certainly multiple style guides do this.)
… instead of quoted triples.