Disambiguate what "each" means in TAG appointment ratification #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
suggested changes
Mar 26, 2024
cwilso
approved these changes
Mar 26, 2024
tantek
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
This is a good improvement. I support landing this WITHOUT closing #836 as I think @martinthomson identified some additional ambiguities to address there.
Co-authored-by: Martin Thomson <[email protected]>
fantasai
reviewed
Mar 27, 2024
hober
approved these changes
Apr 1, 2024
frivoal
added
Closed: Accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #836
Preview | Diff