Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-highlight-api-1] Add highlightsFromPoint() to CSS.highlights #7513 #11507

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

ffiori
Copy link
Contributor

@ffiori ffiori commented Jan 15, 2025

Add highlightsFromPoint() to CSS.highlights as discussed in #7513.

@ffiori ffiori marked this pull request as ready for review January 15, 2025 21:29
@ffiori ffiori marked this pull request as draft January 15, 2025 21:33
@ffiori ffiori changed the title add spec for highlightsFromPoint [css-highlight-api] Add highlightsFromPoint() to CSS.highlights Jan 15, 2025
@ffiori ffiori changed the title [css-highlight-api] Add highlightsFromPoint() to CSS.highlights [css-highlight-api-1] Add highlightsFromPoint() to CSS.highlights Jan 15, 2025
@ffiori ffiori changed the title [css-highlight-api-1] Add highlightsFromPoint() to CSS.highlights [css-highlight-api-1] Add highlightsFromPoint() to CSS.highlights #7513 Jan 15, 2025
@ffiori ffiori requested a review from siliu1 January 17, 2025 20:59
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
@siliu1 siliu1 requested a review from dandclark January 17, 2025 21:22
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
Copy link
Contributor

@dandclark dandclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!
Just nits now.

css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
css-highlight-api-1/Overview.bs Outdated Show resolved Hide resolved
@ffiori ffiori marked this pull request as ready for review January 24, 2025 21:55
@siliu1
Copy link
Contributor

siliu1 commented Jan 25, 2025

LGTM!

@sanketj sanketj merged commit b394536 into w3c:main Jan 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants