Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Add @csstools/stylelint-formatter-github as Stylelint's GitHub formatter #3188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Dec 3, 2024

Stylelint's GitHub formatter was deprecated in v16.8.0. Running npx stylelint "**/*.css" -f github from the lint-css workflow now gives the following error (currently being thrown in #2991):

[stylelint:004] DeprecationWarning: "github" formatter is deprecated
Please use "stylelint-actions-formatters" instead.

This PR uses --custom-formatter @csstools/stylelint-formatter-github, which should be a drop in replacement for -f github

@howard-e
Copy link
Contributor Author

howard-e commented Dec 3, 2024

cc @nschonni @jongund

@howard-e howard-e requested a review from jongund December 3, 2024 20:39
@jongund
Copy link
Contributor

jongund commented Dec 3, 2024

@howard-e
What does this mean for me as an author?
I get alot of CSS linting errors in the high contrast pull request.
What is the best way to fix them?

@howard-e howard-e changed the title Add @csstools/stylelint-formatter-github as Stylelint's GitHub formatter Infrastructure: Add @csstools/stylelint-formatter-github as Stylelint's GitHub formatter Dec 3, 2024
@howard-e howard-e added the Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation label Dec 3, 2024
@howard-e
Copy link
Contributor Author

howard-e commented Dec 3, 2024

@howard-e What does this mean for me as an author?

Looking again at your latest build, this error may be more of a warning instead of forcing a process exit so maybe nothing actually! If I'm wrong on that, you could approve and merge this work into main then merge main into your branch.

I get alot of CSS linting errors in the high contrast pull request. What is the best way to fix them?

Running npm run fix and committing should do the trick. But I just double-checked that the lint-staged setup should be automatically reformatting when committing. Is it possible your git commit actions has a --no-verify happening? Whether from your cli or some tool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants