Dontnoiser reflections #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w23
requested changes
Dec 25, 2024
Из-за ошибки pdf действительно не сосчитался. Я выкинул все расчеты из brdf-функций и написал TODO о том, что в будущем, возможно, все-таки стоило бы этот pdf посчитать. Но я рад и такому результату |
w23
approved these changes
Dec 25, 2024
| if ((ubo.ubo.renderer_flags & RENDERER_FLAG_ONLY_DIFFUSE_GI) != 0) { | ||
| diffuse += specular; | ||
| specular = vec3(0.); | ||
| if (any(equal(reflection_direction, vec3(0.)))) { |
There was a problem hiding this comment.
крайне маловероятно, что (случайный) отражённый луч может иметь какую-либо из компонент в точности равной нулю, но
Suggested change
| if (any(equal(reflection_direction, vec3(0.)))) { | |
| if (all(equal(reflection_direction, vec3(0.)))) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and denoise reflections. For better quality direct reflections (first bounce) calculated separatelly in bounce.comp
For enable reflections, use this cvars:
rt_separated_reflection 1 - enable reflections calculation
rt_spatial_reconstruction 1 - enable spartial reconstruction pass