Specialize parsing of blocks of the same elements #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having read the "Use specialization" section of https://romgrk.com/posts/optimizing-javascript#9-use-specialization I got another idea for performance optimization.
Oftentimes, the lines that define vertices, normals, uvs and faces are grouped. This means that if the parser encounters a line that defines a vertex (starting with
v
), it could switch into the mode of parsing only vertices until it sees something else. In this mode, each next line only needs to be checked if it starts withv
, instead of being considered for any other possibility.This made the parser 24% faster in Safari
And 6% faster in Chrome