Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #14

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Upgrade dependencies #14

wants to merge 7 commits into from

Conversation

andersk
Copy link

@andersk andersk commented Nov 7, 2024

Many of our dependencies (svgicons2svgfont, ttf2woff2, url-join, file-type, read-chunk) are now ESM-only, so we need to convert to ESM as well. This is a breaking change, but it’s the only option going forward.

It’s unclear why this project has both package-lock.json and yarn.lock, but I have updated both. Ideally we should pick one and delete the other; otherwise npm and yarn will fight with each other and repeatedly add useless yarn.lock churn to the Git history.

@andersk andersk mentioned this pull request Nov 7, 2024
@andersk andersk force-pushed the upgrade branch 5 times, most recently from 95195ff to 822309c Compare November 8, 2024 00:16
andersk and others added 7 commits November 8, 2024 18:41
Many of our dependencies (svgicons2svgfont, ttf2woff2, url-join,
file-type, read-chunk) are now ESM-only, so we need to convert to ESM
as well.  This is a breaking change, but it’s the only option going
forward.

Signed-off-by: Anders Kaseorg <[email protected]>
It’s unclear why this project has both package-lock.json and
yarn.lock, but I have updated both.

Signed-off-by: Anders Kaseorg <[email protected]>
Signed-off-by: Anders Kaseorg <[email protected]>
@thiagocoelho
Copy link

Hello there!

I'm using this awesome package webfonts-loader which depends on https://github.com/vusion
webfonts-generator

I've encountered an issue with svgicons2svgfont, where icons are rendered with incorrect dimensions.

I noticed that this PR seems to fix this problem. Could you please let me know if this fix will be officially released soon?

Thanks in advance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants