Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document usage of middlewareModule with Magento 2 integration #1520

Merged
merged 2 commits into from
Apr 19, 2024
Merged

docs: document usage of middlewareModule with Magento 2 integration #1520

merged 2 commits into from
Apr 19, 2024

Conversation

WojtekTheWebDev
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Document usage of middlewareModule with Magento 2 integration

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@WojtekTheWebDev WojtekTheWebDev requested a review from a team as a code owner April 17, 2024 10:18
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e46e482

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mattmaribojoc
mattmaribojoc approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@mattmaribojoc mattmaribojoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but great work

docs/content/4.advanced/custom-queries.md Show resolved Hide resolved
docs/content/2.getting-started/3.supported-features.md Outdated Show resolved Hide resolved
@WojtekTheWebDev WojtekTheWebDev merged commit 38b3582 into refactor/migration-to-middlewareModule Apr 19, 2024
4 checks passed
@WojtekTheWebDev WojtekTheWebDev deleted the docs/migration-to-middleawreModule branch April 19, 2024 10:45
WojtekTheWebDev added a commit that referenced this pull request Apr 19, 2024
@WojtekTheWebDev @mattmaribojoc
refactor: add TSDocs focused on SDK usage and deprecate magentoModule (…
6672edf 
…#1519)

* refactor: prepare migration to middlewareModule

* chore: deprecate magentoModule

* docs: document usage of middlewareModule with Magento 2 integration (#1520)

* docs: document usage of middlewareModule with Magento 2 integration

* Update docs/content/2.getting-started/3.supported-features.md

Co-authored-by: Matt Maribojoc <[email protected]>

---------

Co-authored-by: Matt Maribojoc <[email protected]>

---------

Co-authored-by: Matt Maribojoc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmaribojoc mattmaribojoc mattmaribojoc approved these changes

@skirianov skirianov Awaiting requested review from skirianov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WojtekTheWebDev @mattmaribojoc