Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:try to deal with the template abbreviation of end tag #152

Closed

Conversation

CathLee
Copy link

@CathLee CathLee commented Mar 15, 2024

In #112, I attempted to abbreviate the end tag within the template. I'm not entirely sure about the specific meaning of the end tag. From my perspective, I simply tried to represent <div></div> as <div />.
Additionally, I've written some tests to address this situation, npm run test-unit seems ok.hoping it can be of assistance. Should there be any issues with this approach, I will close my pull request. Thank you.

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit f2da119
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/65f402f588384d0008a3100c
😎 Deploy Preview https://deploy-preview-152--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit f2da119
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/65f402f5bce2f700071f96a8
😎 Deploy Preview https://deploy-preview-152--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CathLee CathLee changed the title Try to deal with the template abbreviation of end tag feat:try to deal with the template abbreviation of end tag Mar 15, 2024
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component cannot be used in template directly. See #151

@sxzz sxzz closed this Mar 15, 2024
@CathLee
Copy link
Author

CathLee commented Mar 16, 2024

ok,i see🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants