fix(resolve): exclude empty optional arguments from params #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-router canceled.
|
packages/router/src/matcher/index.ts
Outdated
| @@ -310,6 +310,12 @@ export function createRouterMatcher( | |||
| // we know the matcher works because we tested the regexp | |||
| params = matcher.parse(path)! | |||
| name = matcher.record.name | |||
|
|
|||
| matcher?.keys.forEach(key => { | |||
There was a problem hiding this comment.
Can the ?. be changed to . instead?
There was a problem hiding this comment.
@skirtles-code
Thank you for your comment.
Oh, it was a remnant from writing outside of this block.
Fixed!
66f824f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2419
Removed if optional parameter is empty
Now the param will match if :to is string and if it is object
In the case of string path, it should not be an empty string parameter(Right?)
, so I thought there would be no problem with excluding it.
However, this may be a breaking change if you have users who were using this
In addition, I added a router-link to Playgound to check the operation.