fixing maintenance time #291
Merged
+6
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wejdross
requested review from
a team,
Kidswiss,
TheBigLee and
zugao
and removed request for
a team
wejdross
commented
Jan 7, 2025
Comment on lines
-439
to
-445
| func validateFQDNs(fqdns []string) error { | ||
| for _, fqdn := range fqdns { | ||
| if !valid.IsDNSName(fqdn) { | ||
| return fmt.Errorf("FQDN %s is not a valid DNS name", fqdn) | ||
| } | ||
| } | ||
| return nil |
There was a problem hiding this comment.
just a cleanup of unused function
wejdross
commented
Jan 7, 2025
| if comp.Spec.Parameters.Service.UseExternalPostgreSQL { | ||
| svc.Log.Info("Adding postgresql instance") | ||
| err = common.NewPostgreSQLDependencyBuilder(svc, comp). | ||
| AddParameters(comp.Spec.Parameters.Service.PostgreSQLParameters). | ||
| SetCustomMaintenanceSchedule(comp.Spec.Parameters.Maintenance.TimeOfDay.AddTime(20 * time.Minute)). |
There was a problem hiding this comment.
with this line we defaulted maintenance time to "00:20:00" for all instances :D
wejdross
commented
Jan 7, 2025
3 tasks
wejdross
force-pushed
the
fix/maintenanceTime
branch
from
fd90976 to
610b30f
Compare
zugao
reviewed
Jan 7, 2025
wejdross
force-pushed
the
fix/maintenanceTime
branch
from
610b30f to
10ca29d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog