Fix quota namespace not found #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the quota namespace was not found. It also fixes a bug that would override the namespace with a wrong name. There's also now an additional check to see if the name of the namespace is empty or not. This helps mitigating wrong patches from the PnT function.
Goreleaser is not happy with a dirty repository, so we clean it up again after the build.
TheBigLee
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the quota namespace was not found. It also fixes a bug that would override the namespace with a wrong name.
There's also now an additional check to see if the name of the namespace is empty or not. This helps mitigating wrong patches from the PnT function.
Also found a bug with the release action, goreleaser was failing due to a dirty repository.
Summary
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog