Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MariaDB service #105

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Add MariaDB service #105

merged 1 commit into from
Nov 29, 2023

Conversation

TheBigLee
Copy link
Member

@TheBigLee TheBigLee commented Nov 21, 2023 •
edited
Loading

Summary

  • This PR bootstraps the new VSHNMariaDB service for our AppCat offering
  • It includes a single instance MariaDB pod and TLS support
  • Not yet included is Backup/Restore, Monitoring, Alerting and Maintenance

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@TheBigLee TheBigLee force-pushed the feature/mariadb branch 11 times, most recently from 8450c91 to 7073ebd Compare November 24, 2023 14:12
@TheBigLee TheBigLee changed the base branch from master to CLI/composition November 24, 2023 14:12
@TheBigLee TheBigLee changed the base branch from CLI/composition to master November 24, 2023 14:12
@TheBigLee TheBigLee force-pushed the feature/mariadb branch 2 times, most recently from 40988a5 to 5a0db93 Compare November 24, 2023 15:33
@TheBigLee TheBigLee marked this pull request as ready for review November 24, 2023 15:35
@TheBigLee TheBigLee requested review from zugao and Kidswiss November 24, 2023 15:36
@TheBigLee TheBigLee force-pushed the feature/mariadb branch 4 times, most recently from d1fe402 to 017cf8d Compare November 24, 2023 18:23
Kidswiss
Kidswiss requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reduce the complexity of the code a bit by just using a constant for the mysql port. Currently, there's no way for the user to actually change it, so we don't have to jump though hoops to expose it.

boostrap/template.go Outdated Show resolved Hide resolved
mariadb.json Outdated Show resolved Hide resolved
pkg/comp-functions/functions/common/netpol.go Show resolved Hide resolved
pkg/comp-functions/functions/common/tls.go Outdated Show resolved Hide resolved
pkg/comp-functions/functions/vshnmariadb/mariadb_deploy.go Outdated Show resolved Hide resolved
pkg/comp-functions/functions/vshnmariadb/mariadb_deploy.go Outdated Show resolved Hide resolved
pkg/comp-functions/functions/vshnmariadb/mariadb_deploy.go Outdated Show resolved Hide resolved
pkg/comp-functions/functions/vshnmariadb/mariadb_deploy.go Show resolved Hide resolved
pkg/comp-functions/functions/vshnmariadb/mariadb_deploy.go Outdated Show resolved Hide resolved
pkg/comp-functions/functions/vshnmariadb/mariadb_deploy.go Outdated Show resolved Hide resolved
@Kidswiss
Copy link
Contributor

Also, please change the title and summary of the PR

@TheBigLee TheBigLee added the enhancement New feature or request label Nov 28, 2023
@TheBigLee TheBigLee force-pushed the feature/mariadb branch 2 times, most recently from c972772 to 7354fd2 Compare November 28, 2023 11:12
@TheBigLee
Copy link
Member Author

Also, please change the title and summary of the PR

Done. Also added missing tests

@TheBigLee TheBigLee requested a review from Kidswiss November 28, 2023 11:19
zugao
zugao requested changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to look at.

crds/vshn.appcat.vshn.io_xvshnminios.yaml Show resolved Hide resolved
docs/modules/ROOT/pages/explanations/bootstrap_api.adoc Outdated Show resolved Hide resolved
@TheBigLee TheBigLee changed the title Feature/mariadb Add MariaDB service Nov 28, 2023
@TheBigLee TheBigLee requested a review from zugao November 28, 2023 13:24
Kidswiss
Kidswiss approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheBigLee
Add MariaDB service
fa08e80 
Signed-off-by: Nicolas Bigler <[email protected]>
zugao
zugao approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheBigLee TheBigLee merged commit fc086d8 into master Nov 29, 2023
3 checks passed
@TheBigLee TheBigLee deleted the feature/mariadb branch November 29, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@Kidswiss Kidswiss Kidswiss approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheBigLee @Kidswiss @zugao