fix: treepy-leftmost, treepy-rightmost #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Functions
treepy-leftmost
andtreepy-rightmost
doesn't represent left and right hand side liketreepy-left
ortreely-right
does.This affects reconstruction of data whenever it's changed.
Most affected is
treepy-rightmost
as it reverses whole lhs when going back to root.Example
What's Changed
Provided patch brings behavior of these function closer to their less specialized counterparts and adds lacking test coverage for them.