Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #94 -- Catch database errors more broadly #97

Merged

Conversation

herrbenesch
Copy link
Contributor

@herrbenesch herrbenesch commented May 3, 2024

psycopg.DatabaseError is a common base for all errors that are directly
related to the database.

How to test

  • Try to provoke a wrong SQL statement
    e.g. give me all blue roses from the database
  • Check the logs for the error and you should get a response

psycopg.DatabaseError is a common base for all errors that are directly
related to the database.
@herrbenesch herrbenesch linked an issue May 3, 2024 that may be closed by this pull request
@herrbenesch herrbenesch self-assigned this May 3, 2024
@herrbenesch herrbenesch added the bug Something isn't working label May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (5474974) to head (b982173).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          19       19           
  Lines         600      600           
=======================================
  Hits          575      575           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@herrbenesch herrbenesch requested a review from amureki May 3, 2024 11:58
@herrbenesch herrbenesch marked this pull request as ready for review May 3, 2024 12:02
Copy link
Member

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@herrbenesch
Copy link
Contributor Author

thanks @amureki

@herrbenesch herrbenesch merged commit 1812024 into main May 3, 2024
7 checks passed
@herrbenesch herrbenesch deleted the 94-undefinedtable-relation-system_status-does-not-exist branch May 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UndefinedTable: relation "system_status" does not exist
2 participants