Introduce pre-commit and ruff #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 95.62% 95.63%
=======================================
Files 17 17
Lines 572 573 +1
=======================================
+ Hits 547 548 +1
Misses 25 25 ☔ View full report in Codecov by Sentry. |
codingjoe
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed quite some obsolete imports and other issues that went unnoticed by black+isort+pydocstyle.
Also, I made several PRs where CI failed with linting issues, which was annoying to get back to and fix by running linters manually.
I decided to replace it all with ruff and also introduce pre-commit to solve these issues.
This also reduced in half the amount of linting jobs running (later we also could get rid of black in favor of ruff formatter)